Update required version of zxcvbn to 0.1.9 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an important performance issue with verification of passwords.
matthewford
approved these changes
Feb 21, 2023
|
@formigarafa thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results produced are still compatible with dropbox/zxcvbn.js 4.4.2 but this one solves an issue with performance that could cause considerable impacts.
This version makes the algorithm to work with performance linear
O(n)in relation to size of passwords, before this change it could be polynomialO(n^c).There are more details on
zxcvbnChangelog and on issue: formigarafa/zxcvbn-rb#6 and the code changes on PR formigarafa/zxcvbn-rb#7.